Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate: add v3 translate text samples with glossary and model #1941

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Jan 9, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2020
@nnegrey nnegrey unassigned lesv Jan 9, 2020
@nnegrey nnegrey marked this pull request as ready for review January 14, 2020 18:48
@nnegrey nnegrey requested a review from a team January 14, 2020 18:48
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok w/ Java 11 only, but is that the standard for this API, and for testing on your repo? (ie. have you made it so that we don't build using Java 7?

@lesv
Copy link
Contributor

lesv commented Jan 14, 2020

I guess it works

@lesv lesv merged commit f1def2a into master Jan 14, 2020
@lesv lesv deleted the translate-text-glossry-model branch January 14, 2020 18:51
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
…odel (#1941)

* translate: add v3 translate text samples with glossary and model

* Update pom to java 11
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…odel (#1941)

* translate: add v3 translate text samples with glossary and model

* Update pom to java 11
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…odel (#1941)

* translate: add v3 translate text samples with glossary and model

* Update pom to java 11
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
…odel (#1941)

* translate: add v3 translate text samples with glossary and model

* Update pom to java 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants